Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): disable automatic mounting of service account tokens #45056

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(security): disable automatic mounting of service account tokens #45056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a147e9
Set automountServiceAccountToken: false for statsd, workers, pgbounc…
gsingh935 Dec 18, 2024
2c1b3c4
Reverting automountserviceaccount to original value for worker
gsingh935 Dec 19, 2024
9664cb0
Merge branch 'main' into patch-4
gsingh935 Dec 19, 2024
ee39a47
Set automountServiceAccountToken: false for webserver
gsingh935 Dec 19, 2024
08a07a5
Update test_pgbouncer.py
gsingh935 Dec 19, 2024
3af3411
Update test_statsd.py
gsingh935 Dec 19, 2024
4b5765a
Merge branch 'main' into patch-4
gsingh935 Dec 19, 2024
ff63e7a
Update automountserviceaccount values.schema.json
gsingh935 Dec 19, 2024
1dbad96
Merge branch 'main' into patch-4
gsingh935 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chart/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5594,7 +5594,7 @@
"automountServiceAccountToken": {
"description": "Specifies if ServiceAccount's API credentials should be mounted onto Pods",
"type": "boolean",
"default": true
"default": false
},
"create": {
"description": "Specifies whether a ServiceAccount should be created.",
Expand Down Expand Up @@ -6782,7 +6782,7 @@
"automountServiceAccountToken": {
"description": "Specifies if ServiceAccount's API credentials should be mounted onto Pods",
"type": "boolean",
"default": true
"default": false
},
"create": {
"description": "Specifies whether a ServiceAccount should be created.",
Expand Down Expand Up @@ -7397,7 +7397,7 @@
"automountServiceAccountToken": {
"description": "Specifies if ServiceAccount's API credentials should be mounted onto Pods",
"type": "boolean",
"default": true
"default": false
},
"create": {
"description": "Specifies whether a ServiceAccount should be created.",
Expand Down
6 changes: 3 additions & 3 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,7 @@ webserver:
serviceAccount:
# default value is true
# ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/
automountServiceAccountToken: true
automountServiceAccountToken: false
# Specifies whether a ServiceAccount should be created
create: true
# The name of the ServiceAccount to use.
Expand Down Expand Up @@ -2096,7 +2096,7 @@ statsd:
serviceAccount:
# default value is true
# ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/
automountServiceAccountToken: true
automountServiceAccountToken: false
# Specifies whether a ServiceAccount should be created
create: true
# The name of the ServiceAccount to use.
Expand Down Expand Up @@ -2181,7 +2181,7 @@ pgbouncer:
serviceAccount:
# default value is true
# ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/
automountServiceAccountToken: true
automountServiceAccountToken: false
# Specifies whether a ServiceAccount should be created
create: true
# The name of the ServiceAccount to use.
Expand Down
2 changes: 1 addition & 1 deletion helm_tests/other/test_pgbouncer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ def test_default_automount_service_account_token(self):
},
show_only=["templates/pgbouncer/pgbouncer-serviceaccount.yaml"],
)
assert jmespath.search("automountServiceAccountToken", docs[0]) is True
assert jmespath.search("automountServiceAccountToken", docs[0]) is False

def test_overridden_automount_service_account_token(self):
docs = render_chart(
Expand Down
2 changes: 1 addition & 1 deletion helm_tests/other/test_statsd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ def test_default_automount_service_account_token(self):
},
show_only=["templates/statsd/statsd-serviceaccount.yaml"],
)
assert jmespath.search("automountServiceAccountToken", docs[0]) is True
assert jmespath.search("automountServiceAccountToken", docs[0]) is False

def test_overridden_automount_service_account_token(self):
docs = render_chart(
Expand Down
2 changes: 1 addition & 1 deletion helm_tests/webserver/test_webserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ def test_default_automount_service_account_token(self):
},
show_only=["templates/webserver/webserver-serviceaccount.yaml"],
)
assert jmespath.search("automountServiceAccountToken", docs[0]) is True
assert jmespath.search("automountServiceAccountToken", docs[0]) is False

def test_overridden_automount_service_account_token(self):
docs = render_chart(
Expand Down
Loading