-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator #45025
base: main
Are you sure you want to change the base?
Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator #45025
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be great to have a unit test to cover this as well
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py
Outdated
Show resolved
Hide resolved
self._export_table_to_point_in_time() | ||
return self._export_table_to_point_in_time() | ||
else: | ||
self._export_entire_data() | ||
return self._export_entire_data() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if adding return statement then there is no need for else
…ub.com/tssahota/airflow into return-export-arn-DynamoDBToS3Operator
Co-authored-by: Vincent <[email protected]>
Enable DynamoDbToS3Operator to return point in time export ARN to x_com to be used by downstream tasks
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.