-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sqa deprecations for airflow core #39211
fix: sqa deprecations for airflow core #39211
Conversation
In theory it should be run against mysql backend, however difficult to say right now, seems like codecov integration broken again and there is difficult to say is this lines covered or not
This might not work as it expected into the 2.0 but better to check, it could be done by the separate PR. That what I found about particular this warning: sqlalchemy/sqlalchemy#7693 (comment) |
Set to rerun it with full test just in case |
7c0c116
to
1a315c1
Compare
related: #28723
fix deprecations for SQLAlchemy 2.0 for Airflow core.
@Taragolis I linked your changes as well in the list.
Further I have noticed 2 things. First of all I fixed an issue that was not listed in the orginal issue. I assume it might was missing as it a mysql specfic, e.g. example Thus it would make sense to run the checks for mysql and any other supported db as well.
Second I could not fix
airflow/cli/commands/task_command.py:202
and I am not really sure if this is really something that needs to be fixed. I went through the SQA docs and it might be a warning we have in 1.4 that will be gone whenever we have 2.0 without any real error. But hard to tell. I will further investigate.Reported in core
airflow/models/taskinstance.py:1869 fixed by Use class-bound attribute directly in SA
lazyload
#39195airflow/models/taskinstance.py:1871 fixed by Use class-bound attribute directly in SA
lazyload
#39195airflow/www/views.py:845
airflow/www/views.py:3455
airflow/www/views.py:3455
airflow/www/views.py:3293
airflow/www/views.py:3293
airflow/jobs/scheduler_job_runner.py:1642 fixed by Use class-bound attribute directly in SA
lazyload
#39195airflow/models/trigger.py:141 fixed by Use class-bound attribute directly in SA
joinedload
#39198airflow/utils/db_cleanup.py:200
airflow/cli/commands/task_command.py:202
airflow/models/taskinstance.py:524 fixed by Use class-bound attribute directly in SA
lazyload
#39195^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.