Migrate XCom model queries to sqlalchemy v2 #37761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to update it to make the tests pass without updating them (to ensure it's b/c) |
Taragolis
reviewed
Feb 28, 2024
dirrao
approved these changes
Feb 28, 2024
uranusjr
reviewed
Feb 28, 2024
airflow/models/xcom.py
Outdated
| @@ -435,7 +439,7 @@ def get_many( | |||
| include_prior_dates: bool = False, | |||
| limit: int | None = None, | |||
| session: Session = NEW_SESSION, | |||
| ) -> Query: | |||
| ) -> Select: | |||
There was a problem hiding this comment.
Hmm, I’m not sure we can change the get_many return type like this since it is considered a public interface. We need to make the session.scalars call a part of this function instead.
There was a problem hiding this comment.
Yes, that's why I converted it to draft: #37761 (comment)
hussein-awala
force-pushed
the
sqlalchemy_v2_xcom
branch
2 times, most recently
from
bc6ee94 to
52448f2
Compare
hussein-awala
force-pushed
the
sqlalchemy_v2_xcom
branch
from
52448f2 to
d19542f
Compare
hussein-awala
commented
Mar 2, 2024
| if first is None: # No matching XCom at all. | ||
| return default | ||
| if map_indexes is not None or first.map_index < 0: | ||
| return XCom.deserialize_value(first) | ||
| return first.value | ||
| query = query.order_by(None).order_by(XCom.map_index.asc()) | ||
| return LazyXComAccess.build_from_xcom_query(query) |
There was a problem hiding this comment.
I will try to find a solution b/c for LazyXComAccess
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #28723