Refactor Sqlalchemy queries to 2.0 style (Part 3) #32177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanikumv
force-pushed
the
sqlalchemy_changes
branch
from
09a3e7d to
66e71dc
Compare
phanikumv
force-pushed
the
sqlalchemy_changes
branch
4 times, most recently
from
0d68ef2 to
52bb22e
Compare
uranusjr
reviewed
Jun 28, 2023
| @@ -1304,10 +1306,10 @@ def _dangling_against_task_instance(session, source_table, dag_run, task_instanc | |||
| ) | |||
|
|
|||
| return ( | |||
| session.query(*[c.label(c.name) for c in source_table.c]) | |||
| select(*[c.label(c.name) for c in source_table.c]) | |||
There was a problem hiding this comment.
Let’s also change this to select(*(...)) (in the other planned PR). There are several of these around in this file too.
There was a problem hiding this comment.
@uranusjr Creating a tuple rather than a list is more efficient?
There was a problem hiding this comment.
This does not create an intermediate tuple but expands a generator directly. With *[] the generator is first realised into a list and then the list is expanded.
phanikumv
force-pushed
the
sqlalchemy_changes
branch
from
52bb22e to
0660b4e
Compare
phanikumv
added
the
use public runners
phanikumv
force-pushed
the
sqlalchemy_changes
branch
2 times, most recently
from
71a2ee7 to
54d3593
Compare
phanikumv
requested review from
ryanahamilton,
bbovenzi and
pierrejeambrun
as code owners
uranusjr
approved these changes
Jul 3, 2023
ephraimbuddy
reviewed
Jul 3, 2023
ephraimbuddy
reviewed
Jul 3, 2023
phanikumv
force-pushed
the
sqlalchemy_changes
branch
from
54d3593 to
c56bafc
Compare
ephraimbuddy
approved these changes
Jul 3, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 4, 2023
…)" This reverts commit 1065687.
potiuk
added a commit
that referenced
this pull request
Jul 4, 2023
|
As discussed in #32343 - this one is reverted and needs to be reapplied with "full tests needed" :(. |
phanikumv
added
the
full tests needed
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the effort to refactor the queries to sqlalchemy 2.0
cc @ephraimbuddy @uranusjr
related: #28723
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.