-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This PR adds view_url to Dagbundles to enable viewing the bundle's version
- Loading branch information
1 parent
5b925dc
commit 7bdbe1e
Showing
5 changed files
with
72 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
|
||
import tempfile | ||
from pathlib import Path | ||
from unittest import mock | ||
|
||
import pytest | ||
from git import Repo | ||
|
@@ -265,3 +266,25 @@ def test_subdir(self, git_repo): | |
files_in_repo = {f.name for f in bundle.path.iterdir() if f.is_file()} | ||
assert str(bundle.path).endswith(subdir) | ||
assert {"some_new_file.py"} == files_in_repo | ||
|
||
@pytest.mark.parametrize( | ||
"repo_url, expected_url", | ||
[ | ||
("[email protected]:apache/airflow.git", "https://github.com/apache/airflow/tree/0f0f0f"), | ||
("[email protected]:apache/airflow.git", "https://gitlab.com/apache/airflow/-/tree/0f0f0f"), | ||
("[email protected]:apache/airflow.git", "https://bitbucket.org/apache/airflow/src/0f0f0f"), | ||
], | ||
) | ||
@mock.patch("airflow.dag_processing.bundles.git.Repo") | ||
@mock.patch.object(GitDagBundle, "_has_version") | ||
def test_view_url(self, mock_has_version, mock_gitrepo, repo_url, expected_url): | ||
mock_has_version.return_value = True | ||
|
||
bundle = GitDagBundle( | ||
name="test", | ||
refresh_interval=300, | ||
repo_url=repo_url, | ||
tracking_ref="main", | ||
) | ||
view_url = bundle.view_url("0f0f0f") | ||
assert view_url == expected_url |