Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for find_package() and clean-up TIFF support #171

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Jan 28, 2025

This is in further support for integration in OpenEXR, which uses find_package()

AcademySoftwareFoundation/openexr#1883

@michaeldsmith
Copy link
Contributor

There is no CI that includes TIFF, right? Have you tested this on Windows and Mac ?

@palemieux
Copy link
Contributor Author

There is no CI that includes TIFF, right? Have you tested this on Windows and Mac ?

CI includes Windows and Mac.

@michaeldsmith
Copy link
Contributor

michaeldsmith commented Jan 28, 2025

There is no CI that includes TIFF, right? Have you tested this on Windows and Mac ?

CI includes Windows and Mac.

CI does not include TIFF. Did you test your changes to TIFF in windows and mac?

@aous72
Copy link
Owner

aous72 commented Jan 29, 2025

Hi Pierre,

Thank you for this useful addition.
I had a quick look, and, in principle, I am fine with it.
I will give them a try tomorrow, and if there are any issues, I will let you know.
I will also read the documentation; many things are beyond my knowledge.

Kind regards,
Aous.

@aous72 aous72 changed the base branch from master to test_pr January 29, 2025 23:56
@aous72 aous72 merged commit 9f266d7 into aous72:test_pr Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants