Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair Turborepo's cache hash #962

Merged
merged 2 commits into from
May 14, 2024
Merged

Repair Turborepo's cache hash #962

merged 2 commits into from
May 14, 2024

Conversation

steveluscher
Copy link
Collaborator

Turborepo essentially was not caching the right things or busting the cache at the right times.

Test Plan

  1. pnpm build
  2. Make a change to packages/wallets/coinbase/src/adapter.ts
  3. pnpm build

Observe:

 Tasks:    48 successful, 48 total
Cached:    41 cached, 48 total
  Time:    58.602s

@steveluscher Graphite App
Copy link
Collaborator Author

steveluscher commented May 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@steveluscher steveluscher requested a review from jordaaash May 13, 2024 23:00
@steveluscher steveluscher changed the base branch from master to 05-13-_pnpm_to_version_9 May 13, 2024 23:16
@steveluscher steveluscher force-pushed the 05-13-repair_turborepo_s_cache_hash branch from 1966215 to f04a7b8 Compare May 13, 2024 23:16
@steveluscher steveluscher mentioned this pull request May 13, 2024
Merged
@steveluscher steveluscher force-pushed the 05-13-_pnpm_to_version_9 branch from 11f24b2 to 808ee3e Compare May 14, 2024 01:49
@steveluscher steveluscher force-pushed the 05-13-repair_turborepo_s_cache_hash branch from f04a7b8 to 6585aba Compare May 14, 2024 01:49
@steveluscher steveluscher force-pushed the 05-13-_pnpm_to_version_9 branch from 808ee3e to 618799e Compare May 14, 2024 01:50
@steveluscher steveluscher force-pushed the 05-13-repair_turborepo_s_cache_hash branch from 6585aba to 8117985 Compare May 14, 2024 01:50
@steveluscher steveluscher force-pushed the 05-13-_pnpm_to_version_9 branch from 618799e to 575dcc7 Compare May 14, 2024 01:53
@steveluscher steveluscher force-pushed the 05-13-repair_turborepo_s_cache_hash branch from 8117985 to 620b5de Compare May 14, 2024 01:53
Base automatically changed from 05-13-_pnpm_to_version_9 to master May 14, 2024 02:34
@steveluscher steveluscher merged commit 39137f4 into master May 14, 2024
@steveluscher steveluscher deleted the 05-13-repair_turborepo_s_cache_hash branch May 14, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaaash jordaaash Awaiting requested review from jordaaash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steveluscher