Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Trezor adapter on Firefox browsers #927

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

gabrielKerekes
Copy link
Contributor

We received a bug report that the Trezor wallet adapter was not available on Firefox. This PR fixes the Trezor adapter on Firefox (and Safari as well although Safari is not supported by Trezor Connect anyways).

Sorry, I didn't notice the !navigator.hid check before which I copied over from Ledger. It is not needed for the Trezor as Trezor doesn't use HID.

How to reproduce

Try the currently released Trezor adapter on Firefox browsers. See e.g. here that Trezor is not available on Firefox while it is available on Chrome.

How to test

Try the updated Trezor adapter e.g. in the example in this repo. Trezor should be available on both Firefox and Chrome.

@mcintyre94
Copy link
Collaborator

Looks good! Could you create a changeset for this please? If you just run npx changeset at the root of the repo on this branch it should identify the trezor package as the only change, just make it a patch version and use your commit message as the summary. Then we'll automatically release a fixed version of the package when this is merged :)

@gabrielKerekes gabrielKerekes force-pushed the fix-trezor-on-firefox branch from 4b94bfb to f159d22 Compare March 14, 2024 13:45
@gabrielKerekes
Copy link
Contributor Author

Is f159d22 alright? I amended the previous commit and force-pushed with the changeset.

@mcintyre94 mcintyre94 merged commit ba90b65 into anza-xyz:master Mar 14, 2024
1 check passed
@mcintyre94
Copy link
Collaborator

Perfect, thanks!

Copy link

@Pjrich1313 Pjrich1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run debug and update nobes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants