Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade bitkeep brand #859

Conversation

DetonateYin2077
Copy link
Contributor

Hi @jordaaash,

Apologies for the inconvenience, but I need to request another review of this PR. The focus is now solely on upgrading the Bitget brand.

Please take a moment to review the changes. For the other valuable updates, like VersionedTransaction and similar features, I'll set up a separate task.

Thank you for your understanding and assistance.

@jordaaash jordaaash mentioned this pull request Dec 7, 2023
@jordaaash
Copy link
Collaborator

I'll handle this in #860. In the future, please

  • Consolidate the changes you want to make before opening a PR.
  • Use the same PR and make changes, don't open multiple PRs after reviews.
  • Incorporate all feedback in the reviews. It sucks to have to review the exact same issues multiple times.
  • Lint the code before opening a PR.
  • Always open from a non-master branch of your fork and allow edits by maintainers.

@jordaaash jordaaash closed this Dec 7, 2023
@DetonateYin2077
Copy link
Contributor Author

I'll handle this in #860. In the future, please

  • Consolidate the changes you want to make before opening a PR.
  • Use the same PR and make changes, don't open multiple PRs after reviews.
  • Incorporate all feedback in the reviews. It sucks to have to review the exact same issues multiple times.
  • Lint the code before opening a PR.
  • Always open from a non-master branch of your fork and allow edits by maintainers.

Thank you for addressing this in PR #860. I truly apologize for the extra work my approach may have caused. Your guidance is invaluable, and I assure you that I will adhere strictly to these best practices in all future PRs. I'm grateful for your patience and understanding. Your feedback has been a valuable learning experience for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants