SVM: API method for setting cache fork graph #3169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
svm-api-fork-graph
branch
2 times, most recently
from
5d4d0f3
to
d0eb47c
Compare
dmakarov
previously approved these changes
Oct 15, 2024
buffalojoec
force-pushed
the
svm-api-fork-graph
branch
from
649ea08
to
abffbd9
Compare
LucasSte
reviewed
Oct 15, 2024
Comment on lines
+206
to
208
| transaction_processor.set_fork_graph_in_program_cache(fork_graph); | ||
|
|
||
| let mut program_cache = transaction_processor.program_cache.write().unwrap(); |
There was a problem hiding this comment.
Maintaining the older method here avoids acquiring the write lock twice.
Comment on lines
+59
to
-64
| // Initialize the mocked fork graph. | ||
| processor.set_fork_graph_in_program_cache(fork_graph); | ||
|
|
||
| { | ||
| let mut cache = processor.program_cache.write().unwrap(); | ||
|
|
||
| // Initialize the mocked fork graph. | ||
| cache.fork_graph = Some(Arc::downgrade(&fork_graph)); | ||
|
|
There was a problem hiding this comment.
Two consecutive write locks here again.
Comment on lines
+217
to
+221
| pub fn set_fork_graph_in_program_cache(&self, fork_graph: Arc<RwLock<FG>>) { | ||
| self.program_cache | ||
| .write() | ||
| .unwrap() | ||
| .set_fork_graph(Arc::downgrade(&fork_graph)); |
There was a problem hiding this comment.
I believe this function can receive a reference to a fork graph, can't it? Like
pub fn set_fork_graph_in_program_cache(&self, fork_graph: &Arc<RwLock<FG>>)
Or maybe:
pub fn set_fork_graph_in_program_cache(&self, fork_graph: &RwLock<FG>)
There was a problem hiding this comment.
Unfortunately the cache's method requires a Weak<RwLock<FG>>, and from what I could tell, you can only obtain a Weak from an Arc.
Comment on lines
+248
to
251
| batch_processor.set_fork_graph_in_program_cache(Arc::new(RwLock::new(MockForkGraph {}))); | ||
|
|
||
| let fork_graph = Arc::new(RwLock::new(MockForkGraph {})); | ||
| { | ||
| let mut program_cache = batch_processor.program_cache.write().unwrap(); |
There was a problem hiding this comment.
Yeah, this kinda stinks. Do you suggest closing this PR then?
There was a problem hiding this comment.
Perhaps this is better? #3203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating a new
TransactionBatchProcessorinstance, you must configure the fork graph of the program cache in order for the cache to work properly. This can trip up many consumers of the SVM API.We typically set this value on the program cache manually through something like this...
... which is just, awful.
Summary of Changes
Add an API method for setting the cache's fork graph, and use it everywhere.