extract native-token crate #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-native-token
branch
3 times, most recently
from
fb2b2ee
to
8ed5880
Compare
joncinque
reviewed
Oct 15, 2024
sdk/program/src/lib.rs
Outdated
| @@ -183,7 +183,6 @@ | |||
| //! [ed25519]: https://ed25519.cr.yp.to/ | |||
| //! [`Keypair`]: https://docs.rs/solana-sdk/latest/solana_sdk/signer/keypair/struct.Keypair.html | |||
| //! [SHA-256]: https://en.wikipedia.org/wiki/SHA-2 | |||
| //! [`Sol`]: native_token::Sol | |||
There was a problem hiding this comment.
Shouldn't this still work thanks to the re-export? If not, we should remove all of the other links here too (can be done in another PR though)
There was a problem hiding this comment.
yeah i don't remember why that line got deleted. Adding it back
kevinheavey
force-pushed
the
extract-native-token
branch
from
4e44dd9
to
5f24b4d
Compare
kevinheavey
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::native_tokenimposes asolana_programrequirement onsolana_svmand also blocks moving outsolana_program::feeSummary of Changes
Move to its own crate and re-export for backwards compatibility