Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract reward-info crate #2971

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

extract reward-info crate #2971

wants to merge 2 commits into from
+94 −40

Conversation

kevinheavey
Copy link

Problem

solana_sdk::reward_type and solana_sdk::reward_info impose a solana-sdk dependency on solana-rpc-client-api

Summary of Changes

  • Move them into a single solana-reward-info crate.
  • Re-export in their old modules and add deprecation notices
  • Make serde optional in the new crate

@kevinheavey kevinheavey force-pushed the reward-info-crate branch 2 times, most recently from eb8a31a to 830c028 Compare September 25, 2024 10:26
@kevinheavey kevinheavey mentioned this pull request Sep 29, 2024
Open
@kevinheavey kevinheavey force-pushed the reward-info-crate branch 4 times, most recently from 6c3993f to 50e756d Compare October 13, 2024 11:48
@kevinheavey kevinheavey mentioned this pull request Oct 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need:merge-assist
Projects
SDK Breakup + Breakout
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinheavey