Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task : Add ability to change backend URL on the setting page #52

Closed
wants to merge 10 commits into from

Conversation

emmanueleclipse
Copy link

### Things done

  • Added the ability to change the backend URL on the settings page
  • Added a pop-up confirmation form
  • Set a different color for the "Save" button in light mode and dark mode

Screenshots
image
image
image

@emmanueleclipse emmanueleclipse changed the title Task : Add ability to change backend URL on the setting page #51 Task : Add ability to change backend URL on the setting page Feb 19, 2024
lib/main.dart Outdated
var lightTheme = ThemeData(
primaryColorDark: Color(0xFF707070),
primaryColorLight: Color(0xFF404040),
inputDecorationTheme: const InputDecorationTheme(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not remove existing styles

lib/main.dart Outdated
),
brightness: Brightness.light,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need that since we have colorScheme

ElevatedButton(
onPressed: () async {
if (_formKey.currentState.validate()) {
if (await confirm(context,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate confirm operation from the if

boolean confirmed = await confim(...

if (confirmed) {....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants