Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform_docs): Restore multiply --hook-config args support. Regression from v1.95.0 #731

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix(terraform_docs): Restore multiply --hook-config args support. Regression from v1.95.0 #731

merged 1 commit into from
Dec 24, 2024

Conversation

MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented Dec 24, 2024 •
edited
Loading

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

We actually faced this issue in before here, but it was eliminated before it merged to master branch

Because of how our parsing works, we get these empty spaces as "beginning of key name", and because " foo" != "foo", all hook-configs except first parsed effectively ignored. This PR removes that extra space.

Fixes #721

How can we test changes

repos:
  - repo: https://github.com/antonbabenko/pre-commit-terraform
    rev: 819893c726df778321faf4772ae429b186887a48
    hooks:
      - id: terraform_docs
        args:
          - --hook-config=--add-to-existing-file=true
          - --hook-config=--create-file-if-not-exist=true

@MaxymVlasov MaxymVlasov marked this pull request as draft December 24, 2024 13:50
@MaxymVlasov MaxymVlasov marked this pull request as ready for review December 24, 2024 13:52
@MaxymVlasov MaxymVlasov mentioned this pull request Dec 24, 2024
Closed
@MaxymVlasov MaxymVlasov merged commit 87143fb into master Dec 24, 2024
6 checks passed
@MaxymVlasov MaxymVlasov deleted the fix/GH-721 branch December 24, 2024 14:06
antonbabenko pushed a commit that referenced this pull request Dec 24, 2024
@semantic-release-bot
chore(release): version 1.96.3 [skip ci]
55d0143 
## [1.96.3](v1.96.2...v1.96.3) (2024-12-24)

### Bug Fixes

* **`terraform_docs`:** Restore multiply `--hook-config` args support. Regression from v1.95.0 ([#731](#731)) ([87143fb](87143fb))
@antonbabenko
Copy link
Owner

This PR is included in version 1.96.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik yermulnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The terraform-docs hook no longer generated since the pre-commit-terraform v1.95.0
3 participants
@MaxymVlasov @antonbabenko @yermulnik