-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform_docs
): Start seamless migration to terraform-docs
markers
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxymVlasov
commented
Aug 27, 2024
And maybe worth to check terraform-socs config provided to hook in case it uses output.template with pre-commit-terraform markers And if we change this config, maybe remove obsolote |
yermulnik
reviewed
Aug 27, 2024
Co-authored-by: George L. Yermulnik <[email protected]>
yermulnik
approved these changes
Aug 28, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Aug 28, 2024
# [1.93.0](v1.92.3...v1.93.0) (2024-08-28) ### Features * **`terraform_docs`:** Start seamless migration to `terraform-docs` markers ([#701](#701)) ([d03f44f](d03f44f))
This PR is included in version 1.93.0 🎉 |
cschroer
added a commit
to cschroer/pre-commit-terraform
that referenced
this pull request
Aug 29, 2024
Ensure compatibility of `terraform_docs` hook on MacOS and Linux by using GNU sed. In PR antonbabenko#701, the `terraform_docs` hook uses `sed` for in-file changes. MacOS requires an extension for the `-i` parameter, unlike GNU sed. The solution is to use GNU sed on both MacOS and Linux to ensure consistent behaviour across operating systems.
cschroer
added a commit
to cschroer/pre-commit-terraform
that referenced
this pull request
Aug 29, 2024
Ensure compatibility of `terraform_docs` hook on MacOS and Linux by using GNU sed. In PR antonbabenko#701, the `terraform_docs` hook uses `sed` for in-file changes. MacOS requires an extension for the `-i` parameter, unlike GNU sed. The solution is to use GNU sed on both MacOS and Linux to ensure consistent behaviour across operating systems.
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an
x
into the box if that apply:Description of your changes
In #699 was mentioned that v1.92.2 break unexpected behavior which requires to be set
- --hook-config=--create-file-if-not-exist=true
.Because we want:
- --hook-config=--create-file-if-not-exist=true
in v2 as one possible solutionI decided that this a time to start gradually switching folks to standard
terraform-docs
markersRelates #699
How can we test changes