Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Python-based
terraform_fmt
hook to better support Windows #652base: master
Are you sure you want to change the base?
feat: New Python-based
terraform_fmt
hook to better support Windows #652Changes from 5 commits
18291bd
9409f77
ef844ce
806a87a
3f3fdd9
a37971b
85269df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start a PR scope thread here:
How much do we want to be implemented in this PR?
1.1. Current
common
functional "as is"1.2. Full
common
functional parity2.1. Just
terraform_fmt
2.2. All hooks fully which fully based on
common
functionalChoose one from 1. and 2.
The current state is 1.1. + 2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.1
+2.1
(+ each hook to be re-implemented with Python in scope of a separate PR)ps: I don't get the difference between
1.1
and1.2
to be honest... 🤷🏻There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.2 Means that
https://github.com/ericfrederich/pre-commit-terraform/blob/18291bd1e3105046592d221426704c2418c34b7c/hooks/common.py#L55-L59
should be implemented too in this PR