Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Google Style Guide Shellcheck Compliance #324

Open
mohitsaxenaknoldus opened this issue Jan 12, 2022 · 4 comments
Open

chore: Google Style Guide Shellcheck Compliance #324

mohitsaxenaknoldus opened this issue Jan 12, 2022 · 4 comments
Labels
on-hold Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Features implemen...

Comments

@mohitsaxenaknoldus
Copy link
Contributor

What problem are you facing?

While working on some of the issues, I noticed we don't follow Google Style Guide. Shellcheck compliance was there but not in all places. We should implement these to have a cleaner and more easily maintainable code in the long run.

I can raise a PR for this if you'd like.

How could pre-commit-terraform help solve your problem?
@mohitsaxenaknoldus mohitsaxenaknoldus added the feature New feature or request label Jan 12, 2022
@yermulnik
Copy link
Collaborator

May worth sync'ing with @MaxymVlasov on this I think.

@MaxymVlasov
Copy link
Collaborator

Feel free to do refactoring, just by small butches (no more than 1-2 days in the row), and mention here when you start to do it.
Have no ongoing refactor work on my side for now.

@mohitsaxenaknoldus mohitsaxenaknoldus mentioned this issue Jan 12, 2022
Closed
4 tasks
@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2022
@MaxymVlasov MaxymVlasov removed feature New feature or request stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 16, 2022
@MaxymVlasov MaxymVlasov changed the title Google Style Guide Shellcheck Compliance chore: Google Style Guide Shellcheck Compliance Feb 16, 2022
@MaxymVlasov MaxymVlasov self-assigned this Oct 15, 2022
@MaxymVlasov
Copy link
Collaborator

Depends on #303

@MaxymVlasov MaxymVlasov removed their assignment Oct 15, 2022
@MaxymVlasov MaxymVlasov added the on-hold Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on-hold Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

No branches or pull requests
3 participants
@yermulnik @MaxymVlasov @mohitsaxenaknoldus