Improve Python version handling #4726
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
requested changes
Nov 6, 2024
|
@cjwatson thanks for this. Just rollback the changes on the generated files and we'll be good to go. |
Checking just the second element of a version tuple is never good style, and it makes it less clear what actual versions of Python are in question. Signed-off-by: Colin Watson <[email protected]>
cjwatson
force-pushed
the
python-version
branch
from
eae136b to
3488025
Compare
|
OK, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking just the second element of a version tuple is never good style, and it makes it less clear what actual versions of Python are in question.