Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly ignore unused var in TypeScript and @typescript-eslint #4709

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

guidsdo
Copy link
Contributor

@guidsdo guidsdo commented Oct 2, 2024

When using some strict TypeScript options, you can't compile the code anymore because of this specific line. Unfortunately I don't know enough about the necessity of the line to help in another way, so that's why I added this simple fix.

There is another error for unused imports in the Lexer file, but I wasn't able to test that one out since that import seemed to have been changes recently.

Copy link
Contributor

@ericvergnaud ericvergnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt merged commit 933c4e0 into antlr:dev Oct 11, 2024
42 checks passed
@guidsdo guidsdo deleted the strict-ts-error-fix branch October 11, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants