feat: Use Go min/max builtins #4620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The min and max builtins are available since Go 1.21[^1]. The github.com/antlr4-go/antlr/v4 is specifying Go 1.22 in its go.mod file, so the builtins can be used. [^1]: https://go.dev/doc/go1.21#language Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
go-min-max-builtins
branch
from
14a8984 to
5d979f2
Compare
|
The antlr4/runtime/Go/antlr/v4/go.mod Line 3 in 6197d6c Which obviously this PR is not compatible with. I got confused because https://github.com/antlr4-go/antlr is using Go 1.22: https://github.com/antlr4-go/antlr/blob/4d7e18847d8881a176db3d7cca909e3f3942a05f/go.mod#L3 Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
minandmaxbuiltins are available since Go 1.211. The github.com/antlr4-go/antlr/v4 is specifying Go 1.22 in its go.mod file, so the builtins can be used.Footnotes
https://go.dev/doc/go1.21#language ↩