chore: extract duplicate test setup code into shared helper #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate BrowserTool initialization code that was repeated across multiple test files by creating a shared createBrowserTool helper function. The helper encapsulates: - BrowserTool instantiation with default dimensions - Test context setup including page, browser, and testRun - Playwright object enhancement with custom request.newContext Changes: - Created test-helpers.ts with createBrowserTool function (+55 lines) - Simplified test-browser.ts (-25 lines) - Simplified test-github-login.ts (-75 lines, 3 occurrences) - Simplified test-keyboard.ts (-25 lines) - Simplified test-email-rendering.ts (-22 lines) Net reduction: 92 lines removed
|
@helloworld is attempting to deploy a commit to the Antiwork Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rmarescu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate BrowserTool initialization code that was repeated across multiple test files by creating a shared createBrowserTool helper function.
What changed
test-helpers.tswithcreateBrowserToolfunction that encapsulates the common setupThe helper encapsulates:
Impact
Net reduction: 92 lines removed 🎉
This makes the test code more maintainable and reduces duplication significantly.