Migration of checkout page #3160

yashranaway · 2026-01-26T17:12:20Z

Issue: #3042
Fixes: #3042

Previous PR: #3081

Description

Problem

The checkout page currently uses React on Rails with ERB templates, which is inconsistent with our ongoing migration to Inertia.js. This creates maintenance overhead and prevents us from leveraging Inertia's benefits like simplified data passing and better SPA-like navigation.

Solution

Migrate the public checkout page from React on Rails to Inertia while preserving all existing functionality:

Move checkout logic from server-components/CheckoutPage.tsx to components/Checkout/CheckoutPageContent.tsx
Create new Inertia page at pages/Checkout/Index.tsx with disableLayout = true
Update controller to use render inertia: instead of ERB + react_component
Delete the old ERB view, server component, SSR registration, and checkout pack
Update tests to use Inertia test helpers with actual prop value assertions

Before/After

Before

Screen.Recording.2026-01-24.at.4.11.04.AM.mov

After

Logged out

Screen.Recording.2026-01-24.at.4.12.11.AM.mov

Logged in

Screen.Recording.2026-01-24.at.4.13.27.AM.mov

Test Results

Checklist

I have read the contributing guidelines
I have watched Gumroad PR review livestreams
I have performed a self-review and left review comments on my PR
I have added/updated tests for my changes

AI Disclosure

Claude Code (Claude Opus 4.5) was used as a coding assistant for this migration - helping with code extraction, Inertia patterns, and test updates.

yashranaway

Self-review comments for the Checkout page Inertia migration.

app/controllers/checkout_controller.rb

app/javascript/pages/Checkout/Index.tsx

app/javascript/components/Checkout/CheckoutPageContent.tsx

yashranaway · 2026-01-26T17:25:53Z

@EmCousin Addressed all the review comments from #3081, could you please take a look again?

ershad · 2026-01-28T16:07:17Z

@claude review the PR.

claude · 2026-01-28T16:07:39Z

Claude encountered an error —— View job

Command failed: git fetch origin --depth=20 3042-migrate-checkout-to-inertia

I'll analyze this and get back to you.

Pradumn27

Hey @yashranaway _a, added some comments, please check.

Also the issue mentions to migrate:
Internal API endpoints
I don't see any endpoints getting migrated can you list the reason(if any) or migrate the APIs too if possible

app/controllers/checkout_controller.rb

Pradumn27 · 2026-01-29T21:19:12Z

app/javascript/pages/Checkout/Index.tsx

inline the CheckoutPage component here directly and use the .loggedInUserLayout to get the logged in user provider wrappers, won't need this created wrapper then

Pradumn27 · 2026-01-29T21:21:10Z

app/views/checkout/index.html.erb

@@ -1,3 +0,0 @@
-<%= render("shared/recaptcha_script") %>


where is this loaded now?

@yashranaway still don't see this being loaded in the component

Pradumn27 · 2026-01-29T21:22:24Z

spec/controllers/checkout_controller_spec.rb

-          html = Nokogiri::HTML.parse(response.body)
-          expect(html.xpath("//meta[@property='gr:logged_in_user:id']/@content").text).to eq(user.external_id)


why is this removed?

Pradumn27 · 2026-01-29T21:22:48Z

spec/controllers/checkout_controller_spec.rb

          end
        end

-        context "when the cart matching the `cart_id` query param has the `browser_guid` same as the current `_gumroad_guid` cookie value"  do


seems unnecessry space, revert

yashranaway · 2026-01-30T03:06:57Z

Hey @Pradumn27 _a , updated as per review:

Migrated the internal cart API following the same pattern as other Inertia migrations (collaborators, etc.)

Api::Internal::CartsController → Checkout::CartsController
/api/internal/cart → /checkout/cart
Updated frontend to use Routes.checkout_cart_path()

Pradumn27

@yashranaway _a

Pradumn27 · 2026-02-01T10:49:28Z

app/controllers/checkout/carts_controller.rb

why change the controller location? these are still internal apis just rendered via inertia

Reverted, cart API stays at Api::Internal::CartsController. My bad, only the page itself needed to move to Inertia.

app/javascript/pages/Checkout/Index.tsx

Pradumn27 · 2026-02-01T10:51:32Z

spec/controllers/checkout/carts_controller_spec.rb

Yep reverted this too, spec is back at api/internal/.

Pradumn27 · 2026-02-01T10:52:43Z

app/views/checkout/index.html.erb

@@ -1,3 +0,0 @@
-<%= render("shared/recaptcha_script") %>


@yashranaway still don't see this being loaded in the component

… page, fix imports and spacing

yashranaway · 2026-02-01T11:59:12Z

@yashranaway still don't see this being loaded in the component

@Pradumn27 _a The recaptcha script is already loaded dynamically by the useRecaptcha hook in PaymentForm.tsx — it creates the script tag in the DOM itself. So the ERB partial was redundant.

yashranaway added 2 commits January 26, 2026 22:39

Migration of checkout page

c2c248b

Address review comments

1e6b1be

yashranaway had a problem deploying to ci-protected January 26, 2026 17:12 — with GitHub Actions Error

yashranaway changed the title ~~3042 migrate checkout to inertia~~ Migration of checkout page Jan 26, 2026

yashranaway commented Jan 26, 2026

View reviewed changes

yashranaway marked this pull request as ready for review January 26, 2026 17:25

Merge branch 'main' into 3042-migrate-checkout-to-inertia

9588e4f

ershad had a problem deploying to ci-protected January 28, 2026 16:07 — with GitHub Actions Error

Pradumn27 suggested changes Jan 29, 2026

View reviewed changes

neetogit-bot bot assigned yashranaway and unassigned yashranaway Jan 29, 2026

fixes

7756a52

yashranaway had a problem deploying to ci-protected January 30, 2026 03:06 — with GitHub Actions Error

neetogit-bot bot assigned Pradumn27 and unassigned yashranaway Jan 30, 2026

Merge main into 3042-migrate-checkout-to-inertia

e081100

yashranaway had a problem deploying to ci-protected January 30, 2026 03:10 — with GitHub Actions Error

yashranaway marked this pull request as draft January 30, 2026 03:18

fixes 2

e39e009

yashranaway had a problem deploying to ci-protected January 30, 2026 03:22 — with GitHub Actions Error

yashranaway marked this pull request as ready for review January 30, 2026 03:22

fix

6482789

yashranaway had a problem deploying to ci-protected January 30, 2026 03:25 — with GitHub Actions Error

Pradumn27 suggested changes Feb 1, 2026

View reviewed changes

neetogit-bot bot assigned yashranaway Feb 1, 2026

neetogit-bot bot unassigned Pradumn27 Feb 1, 2026

Address review comments: revert cart API to internal, inline checkout…

160f14b

… page, fix imports and spacing

yashranaway had a problem deploying to ci-protected February 1, 2026 11:56 — with GitHub Actions Error

Merge branch 'main' into 3042-migrate-checkout-to-inertia

e844bd7

yashranaway requested a deployment to ci-protected February 1, 2026 11:56 — with GitHub Actions Waiting

neetogit-bot bot assigned Pradumn27 and unassigned yashranaway Feb 1, 2026

		html = Nokogiri::HTML.parse(response.body)
		expect(html.xpath("//meta[@property='gr:logged_in_user:id']/@content").text).to eq(user.external_id)

Migration of checkout page #3160

Are you sure you want to change the base?

Migration of checkout page #3160

Uh oh!

Conversation

yashranaway commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Solution

Before/After

Before

After

Logged out

Logged in

Test Results

Checklist

AI Disclosure

Uh oh!

yashranaway left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yashranaway commented Jan 26, 2026

Uh oh!

ershad commented Jan 28, 2026

Uh oh!

claude bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pradumn27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashranaway commented Jan 30, 2026

Uh oh!

Pradumn27 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashranaway commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yashranaway commented Jan 26, 2026 •

edited

Loading

claude bot commented Jan 28, 2026 •

edited

Loading

yashranaway commented Feb 1, 2026 •

edited

Loading