Fix: Suspending Account For TOS Violation Suspends Related PayPal Accounts For Fraud

[sm17p]

Closes: #2830

Root Cause

after_transition any => %i[suspended_for_fraud suspended_for_tos_violation], :do => :suspend_sellers_other_accounts

We had a state transition setup for suspending related accounts for fraud whenever a creator was suspended for TOS violation

Solution

We now only suspend related accounts for fraud when a creator is suspended for fraud

Test Results

---

Checklist

• I have read the contributing guidelines
• I have watched Gumroad PR review livestreams
• I have performed a self-review and left review comments on my PR
• I have added/updated tests for my changes

---

AI Disclosure

No AI was used for this PR

[sm17p]

Please have a look this is ready for review 🙏

[sm17p]

Going by the spec, this seems safe unless I'm missing some key information.

[nyomanjyotisa]

gumroad/app/sidekiq/check_payment_address_worker.rb

Lines 11 to 14 in a1c6014

	banned_accounts_with_same_payment_address = User.where(
	payment_address: user.payment_address,
	user_risk_state: ["suspended_for_tos_violation", "suspended_for_fraud"]
	)

Thanks for the PR. I think we need to update this as well, to make it consistent

[sm17p]

gumroad/app/sidekiq/check_payment_address_worker.rb

Lines 11 to 14 in a1c6014

	banned_accounts_with_same_payment_address = User.where(
	payment_address: user.payment_address,
	user_risk_state: ["suspended_for_tos_violation", "suspended_for_fraud"]
	)

Thanks for the PR. I think we need to update this as well, to make it consistent

I thought about that but I was not fully sure about it.

My thought process was that if someone was suspended for TOS violation and they create/upate another account for selling, then they are clearly trying to commit a fraud?

Maybe we can ask support before we route accounts suspended for TOS violation to flag for TOS, wdyt?