Added Support to fetch aws region from aws config file .aws/config #537 #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: namanvats <[email protected]>
namanvats
changed the title
JDKardia
requested changes
Jul 2, 2024
| @@ -116,6 +117,8 @@ def __init__( | |||
|
|
|||
| self.aws_access_key = aws_access_key | |||
|
|
|||
| session = boto3.Session() | |||
| aws_region = session.region_name | |||
There was a problem hiding this comment.
This is almost what we want! Ideally we'd want to set aws_region in order of specificity:
- specific region passed as argument
- specific region passed as environment variable
- specific region within config
- default to us-east-1
however, as written in this PR, this would be:
- specific region within config
- specific region passed as argument
- specific region passed as environment variable
- default to us-east-1
if you could correct the ordering of assignment, that would be wonderful.
|
Thank you for the PR. We hope to take a look soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support to fetch the AWS region name from the ~/.aws/config file and use the environment variable as a fallback if the aws config is absent. It defaults to us-east-1 in case both of them are not present. It leverages boto3 which is already present in requirements. So no changes to requirements are required.
Tries to fix the issue raised here : #537