fix: dropdown 关闭没有动画效果 #6813
Open
fix: dropdown 关闭没有动画效果 #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
issues: #6747 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6813 +/- ##
==========================================
- Coverage 92.72% 92.70% -0.02%
==========================================
Files 335 335
Lines 7198 7199 +1
Branches 1767 1804 +37
==========================================
Hits 6674 6674
+ Misses 516 490 -26
- Partials 8 35 +27 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Jan 8, 2025
| const cls = classNames(`${classPrefix}-content`, { | ||
| [`${classPrefix}-content-hidden`]: !active, | ||
| }) | ||
| const cls = classNames(`${classPrefix}-content`) |
There was a problem hiding this comment.
是否可以监听一下动画，结束了加上 hidden。否则元素一直都会留在那里
There was a problem hiding this comment.
我看Popup组件那里顶层已经有了，是不是可以不用再dropdown这里加了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.