Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Check pre/post license during AEDT launch #5730

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Feb 4, 2025

Description

Provide a warning if there are not available licenses.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (8214b24) to head (a0db972).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5730   +/-   ##
=======================================
  Coverage   85.20%   85.21%           
=======================================
  Files         156      156           
  Lines       61071    61076    +5     
=======================================
+ Hits        52035    52044    +9     
+ Misses       9036     9032    -4     

@Samuelopez-ansys Samuelopez-ansys merged commit b191b67 into main Feb 4, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/use_manufacturable_var_optimetrics branch February 4, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants