Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use manufacturable variation in optimetrics #5726

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Feb 3, 2025

Description

Available argument was not working

Issue linked

Clsoe #5725

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.21%. Comparing base (3c863dc) to head (abe27c5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5726   +/-   ##
=======================================
  Coverage   85.20%   85.21%           
=======================================
  Files         156      156           
  Lines       61070    61071    +1     
=======================================
+ Hits        52037    52039    +2     
+ Misses       9033     9032    -1     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a comment though

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 3, 2025 16:06
@Samuelopez-ansys Samuelopez-ansys merged commit 8559afc into main Feb 4, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/use_manufacturable_var_optimetrics branch February 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants