Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix delete port #5713

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FIX: Fix delete port #5713

wants to merge 2 commits into from

Conversation

amichel0205
Copy link
Contributor

@amichel0205 amichel0205 commented Jan 31, 2025

Description

To fix issue with function _delete port added an option to delete only port or port and geometry (same as option in AEDT UI)

Please provide a brief description of the changes made in this pull request.

Issue linked

close #5710

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@amichel0205 amichel0205 self-assigned this Jan 31, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.41%. Comparing base (174de93) to head (8ab386a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5713       +/-   ##
===========================================
+ Coverage   18.20%   79.41%   +61.20%     
===========================================
  Files         156      156               
  Lines       61103    61105        +2     
===========================================
+ Hits        11125    48527    +37402     
+ Misses      49978    12578    -37400     

@Samuelopez-ansys
Copy link
Member

I have canceled the workflow, until the unit test is not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With delete_port(self, name) function not only the port is deleted but the geometry as well
3 participants