Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: New extension version manager #5702

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Jan 29, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Close #5703

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a hui-zhou-a linked an issue Jan 29, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 352 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (cd7ed64) to head (cc45e3f).
Report is 1 commits behind head on main.

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5702      +/-   ##
==========================================
- Coverage   85.21%   84.72%   -0.49%     
==========================================
  Files         156      157       +1     
  Lines       61107    61459     +352     
==========================================
  Hits        52072    52072              
- Misses       9035     9387     +352     

@Samuelopez-ansys
Copy link
Member

@hui-zhou-a This extension is great! But could you please use the same style than the others? I think you can see the choke designer one which has already multi tabs like this one and probably it will be easier for you to adapt.

The icon of the app when it is opened, is not the PyAnsys logo, and to respect consistency with the other extension you should also import it.

In summary, I think you could check the choke_designer toolkit and try to adapt the style

@hui-zhou-a hui-zhou-a changed the title New extension version manager FEAT: New extension version manager Feb 3, 2025
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an extension to manage pyaedt pyedb versions
3 participants