-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accidental plugin activation #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
priyamsahoo and
shatakshiiii
and removed request for
a team
October 20, 2023 11:24
ssbarnea
changed the title
Avoid plugin misaactivation with random ansible_ prefixed fixtures
Avoid accidental plugin activation
Oct 20, 2023
Fixes a bug where a randomly named fixture caused plugin activation even if the project would not make any use of pytest-ansible, causing a runtime error due to the assertion of missing arguments.
ssbarnea
added a commit
that referenced
this pull request
Oct 27, 2023
This fixed a bug where console redirection made by molecule affected pytest execution by adding one new extra newline at each test. Also this removes use of a deprecated function from molecule.
ssbarnea
added a commit
that referenced
this pull request
Oct 28, 2023
This fixed a bug where console redirection made by molecule affected pytest execution by adding one new extra newline at each test. Also this removes use of a deprecated function from molecule.
ssbarnea
added a commit
that referenced
this pull request
Oct 28, 2023
This fixed a bug where console redirection made by molecule affected pytest execution by adding one new extra newline at each test. Also this removes use of a deprecated function from molecule.
ssbarnea
added a commit
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a randomly named fixture caused plugin activation even if the project would not make any use of pytest-ansible, causing a runtime error due to the assertion of missing arguments.
This affected ansible-lint project.
Fixes: #196