Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency to ansible-core #200

Closed
wants to merge 1 commit into from
Closed

Add missing dependency to ansible-core #200

wants to merge 1 commit into from

Conversation

cristianonicolai
Copy link
Contributor

This avoids having a ModuleNotFoundError: No module named 'ansible' when ansible-core module is not installed.

The version used is the same as ansible-lint and molecule.

@cristianonicolai cristianonicolai requested a review from a team as a code owner October 20, 2023 08:01
@cristianonicolai cristianonicolai requested review from audgirka and removed request for a team October 20, 2023 08:01
@cristianonicolai cristianonicolai temporarily deployed to ack October 20, 2023 08:01 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:02 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to ack October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 20, 2023 08:20 — with GitHub Actions Inactive
ssbarnea
ssbarnea requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly is not so easy, we need few more things to do it correctly.

@ssbarnea ssbarnea closed this Oct 20, 2023
@cristianonicolai cristianonicolai deleted the host_fix branch October 23, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
None yet
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianonicolai @ssbarnea