Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml and tox.ini formatting #187

Closed
wants to merge 1 commit into from
Closed

toml and tox.ini formatting #187

wants to merge 1 commit into from

Conversation

cristianonicolai
Copy link
Contributor

No description provided.

@cristianonicolai cristianonicolai temporarily deployed to ack October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 11, 2023 06:34 — with GitHub Actions Inactive
ssbarnea
ssbarnea reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am inclined to using prettier for auto-formatting as it does support toml via a plugin. Sorting part is less important.

Prettier is also intergrated with vscode decently, which i don't thing is the case with other formatters like this one.

Did you see this used in one of our projects?

@ssbarnea ssbarnea added the bug label Oct 11, 2023
@ssbarnea ssbarnea temporarily deployed to ack October 11, 2023 11:05 — with GitHub Actions Inactive
@cristianonicolai
Copy link
Contributor Author

Closin

I am inclined to using prettier for auto-formatting as it does support toml via a plugin. Sorting part is less important.

Prettier is also intergrated with vscode decently, which i don't thing is the case with other formatters like this one.

Did you see this used in one of our projects?

@ssbarnea even after applying Prettier on #191, it doesn't seem to update toml and tox.ini files in such a way as this one does. Should we still discard this?

@cristianonicolai cristianonicolai temporarily deployed to ack October 13, 2023 07:12 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai temporarily deployed to test October 13, 2023 07:13 — with GitHub Actions Inactive
@cristianonicolai cristianonicolai marked this pull request as ready for review October 13, 2023 07:16
@ssbarnea
Copy link
Member

No longer needed

@ssbarnea ssbarnea closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea left review comments

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianonicolai @ssbarnea