-
Notifications
You must be signed in to change notification settings - Fork 3.6k
AAP-52090 Synchronize branches #16092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Remove AWX from display text Co-authored-by: Hao Liu <[email protected]>
* unpin channels-redis The bug that initially caused the upgrade block has been resolved django/channels_redis#332 * replace aioredis Exception with a redis Exception Version 4.0.0 of channel-redis migrated the underlying Redis library from aioredis to redis-py. The Exception has been changed to an equivalent * remove unused license * remove UPGRADE BLOCKER in README * remove hiredis it was an indirect dependency from aioredis which was removed * remove unused license * add back hiredis it's potentially providing a performance boost. install explicitly as a part of redis. upgrade to more recent version * remove UPGRADE BLOCKER for hiredis it was also addressed as a part of this PR
Signed-off-by: Rick Elrod <[email protected]>
Refs ansible/django-ansible-base#447 Signed-off-by: Rick Elrod <[email protected]>
I had the luck of running into this race condition that broke my deployment. No instance was ever able to register because on running "awx-manage" in some check of a setting, it would end up failing here with ``` File "/var/lib/awx/venv/awx/lib64/python3.11/site-packages/awx/conf/license.py", line 10, in _get_validated_license_data return get_licenser().validate() ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/var/lib/awx/venv/awx/lib64/python3.11/site-packages/awx/main/utils/licensing.py", line 453, in validate automated_since = int(Instance.objects.order_by('id').first().created.timestamp()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'created' ```
…nsible#15453) (ansible#6661) * Rewrite more access logic in terms of permissions instead of roles * Cut down supported logic because that would not work anyway * Remove methods not needed anymore * Create managed roles in test before delegating permissions
Adds the following managed Role Definitions Controller Team Admin Controller Team Member Controller Organization Admin Controller Organization Member These have the same permission set as the platform roles (without the Controller prefix) Adding members to teams and orgs via the legacy RBAC system will use these role definitions. Other changes: - Bump DAB to 2024.08.22 - Set ALLOW_LOCAL_ASSIGNING_JWT_ROLES to False in defaults.py. This setting prevents assignments to the platform roles (e.g. Team Member). Signed-off-by: Seth Foster <[email protected]>
…ansible#6668) * Fallback to use subscription cred for analytic Fall back to use SUBSCRIPTION_USERNAME/PASSWORD to upload analytic to if REDHAT_USERNAME/PASSWORD are not set * Improve error message * Guard against request with no query or data * Add test for _send_to_analytics Focus on credentials * Supress sonarcloud warning about password * Add test for analytic ship Co-authored-by: Hao Liu <[email protected]>
* Prevent job pod from mounting serviceaccount token * Add serializer validation for cg pod_spec_override Prevent automountServiceAccountToken to be set to true and provide an error message when automountServiceAccountToken is being set to true
…e#6653) Fixes bug where creating a new user will request a new awx_sessionid cookie, invalidating the previous session. Do not refresh session if updating or creating a password for a different user. Signed-off-by: Seth Foster <[email protected]>
…ansible#15457) (ansible#6669) Co-authored-by: David Newswanger <[email protected]>
used in analytic
Signed-off-by: Rick Elrod <[email protected]>
…nsible#6677) This is to emphasize that this role is specific to controller component. That is, not an auditor for the entire AAP platform. Signed-off-by: Seth Foster <[email protected]>
REDHAT_USERNAME and REDHAT_PASSWORD are default to empty string instead of None
User and Team assignments using the DAB RBAC system will be translated back to the old Role system. This ensures better backward compatibility and addresses some inconsistences in the UI that were relying on older RBAC endpoints. Signed-off-by: Seth Foster <[email protected]> Co-authored-by: Alan Rominger <[email protected]>
…ible#6690) Fixes: https://issues.redhat.com/browse/AAP-30995 Co-authored-by: Ladislav Smola <[email protected]>
…5495) (ansible#6693) * fix: avoid race conditions when removing multiple instance groups at once * remove unused imports
# Add a postfix to the UI URL patterns for UI URL generated by the API # example if set to '' UI URL generated by the API for jobs would be $TOWER_URL/jobs # example if set to 'execution' UI URL generated by the API for jobs would be $TOWER_URL/execution/jobs Co-authored-by: Hao Liu <[email protected]>
…#15518) (ansible#6695) * Fix: change to url in platform ui (ansible#15518) * Fix instance UI URL generated by API (ansible#15517) --------- Co-authored-by: Peter Braun <[email protected]>
Adding credential and execution environment roles validates that the user belongs to the same org as the credential or EE. In some situations, the user-org membership has not yet been synced from gateway to controller. In this case, controller will make a request to gateway to check if the user is part of the org. Signed-off-by: Seth Foster <[email protected]>
…le#6673) Middleware is from django_ansible_base
Next, this is probably an obvious one
|
* created manual sync for role definition * made changes for only read role
Bump migrations and delete some files Resolve remaining conflicts Fix requirements Flake8 fixes Prefer devel changes for schema Use correct versions Remove sso connected stuff Update to modern actions and collection fixes Remove unwated alias Version problems in actions Fix more versioning problems Update warning string Messed it up again Shorten exception More removals Remove pbr license Remove tests deleted in devel Remove unexpected files Remove some content missed in the rebase Use sleep_task from devel Restore devel live conftest file Add in settings that got missed Prefer devel version of collection test Finish repairing .github path Remove unintended test file duplication Undo more unintended file additions
cff8d0f
to
55a7591
Compare
not sure why these lines didn't get removed, here is the commit c2c0f2b it's now RESOLVED |
) | ||
|
||
|
||
def policy_as_code_validate(serializer, attrs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if policy as code is intended to be in awx
stood up aap-gateway/aap-dev alongside awx running with this branch and everything started successfully ✔️ |
bb795d1
to
a285843
Compare
|
SUMMARY
Update
devel
to reduce branch drift.The merge method is "faked", which was:
The commit before the branch point
cb2ad41
From #15427
ISSUE TYPE
COMPONENT NAME