Skip to content

fix(desktop): avoid sidecar health-check timeout on shell startup#13925

Merged
Brendonovich merged 2 commits intoanomalyco:devfrom
ysm-dev:fix/desktop-sidecar-shell-timeout
Feb 17, 2026
Merged

fix(desktop): avoid sidecar health-check timeout on shell startup#13925
Brendonovich merged 2 commits intoanomalyco:devfrom
ysm-dev:fix/desktop-sidecar-shell-timeout

Conversation

@ysm-dev
Copy link
Contributor

@ysm-dev ysm-dev commented Feb 17, 2026

Fixes #13926

What does this PR do?

Desktop sidecar startup currently runs through an interactive login shell (-il). On some machines with heavier interactive shell init, this delays sidecar startup until the desktop health check times out.

This switches sidecar spawn to non-interactive login mode (-l -c) so login env setup is still applied without interactive shell hooks. It also fixes kill-channel handling so we only kill the child on an explicit kill signal, not when the channel closes.

How did you verify your code works?

  • Reproduced the failure locally with bun dev:desktop (Health check timed out).
  • Confirmed shell-related behavior with SHELL=/bin/sh bun dev:desktop.
  • Verified startup works again after this change with default shell.
  • Ran cargo check in packages/desktop/src-tauri.

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@ysm-dev
Copy link
Contributor Author

ysm-dev commented Feb 17, 2026

Thanks for the catch — I opened #13926 and linked it in the PR description via Fixes #13926.

@Brendonovich Brendonovich enabled auto-merge (squash) February 17, 2026 15:29
@Brendonovich Brendonovich merged commit d055c1c into anomalyco:dev Feb 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop sidecar spawn can time out on macOS with interactive shell startup

2 participants