fix(desktop): avoid sidecar health-check timeout on shell startup#13925
Merged
Brendonovich merged 2 commits intoanomalyco:devfrom Feb 17, 2026
Merged
fix(desktop): avoid sidecar health-check timeout on shell startup#13925Brendonovich merged 2 commits intoanomalyco:devfrom
Brendonovich merged 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
Author
|
Thanks for the catch — I opened #13926 and linked it in the PR description via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13926
What does this PR do?
Desktop sidecar startup currently runs through an interactive login shell (
-il). On some machines with heavier interactive shell init, this delays sidecar startup until the desktop health check times out.This switches sidecar spawn to non-interactive login mode (
-l -c) so login env setup is still applied without interactive shell hooks. It also fixes kill-channel handling so we only kill the child on an explicit kill signal, not when the channel closes.How did you verify your code works?
bun dev:desktop(Health check timed out).SHELL=/bin/sh bun dev:desktop.cargo checkinpackages/desktop/src-tauri.