Skip to content

feat(tui): display TPS metric + minimal ripgrep path fix#13892

Open
Daltonganger wants to merge 4 commits intoanomalyco:devfrom
Daltonganger:daltonganger/pr-12721-plus-rgfix-v2
Open

feat(tui): display TPS metric + minimal ripgrep path fix#13892
Daltonganger wants to merge 4 commits intoanomalyco:devfrom
Daltonganger:daltonganger/pr-12721-plus-rgfix-v2

Conversation

@Daltonganger
Copy link

@Daltonganger Daltonganger commented Feb 16, 2026

Summary

  • Includes all changes from feat(tui): add tokens per second to response footer #12721 (TPS display + screenshot)
  • Adds one minimal follow-up fix in packages/opencode/src/file/ripgrep.ts
  • Makes rg resolution safer by rejecting invalid Windows POSIX-style paths and probing resolved binaries before spawn

Why

PR #12721 shows three failing checks where two are real e2e failures caused by invalid/unusable rg paths and the third is a gate job failure. This keeps scope minimal and targets only ripgrep resolution robustness.

Linked PRs

Closes #6096
Fixes #5374

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@Daltonganger
Copy link
Author

@rekram1-node This PR is a direct follow-up to #12721.

It carries over all feature changes from #12721 and adds one minimal ripgrep resolver fix aimed at the e2e failures.

Cross-reference:

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search results, the PR described appears to be a follow-up to #12721, which is the original implementation. Here's what I found:

Related PR:

Why it's related: PR #13892 (the current PR) explicitly states it includes all changes from #12721 and adds a minimal follow-up fix for ripgrep path resolution. This is a direct continuation, not a duplicate.

Additional context:

Conclusion: PR #13892 is not a duplicate—it's a documented follow-up to #12721 that builds upon the TPS display feature.

john and others added 3 commits February 16, 2026 22:35
Adds TPS calculation and display to message footers. Tracks firstToken
timestamp during streaming and calculates throughput for completed text
responses. Filters out tool calls and fast responses to avoid noise.

Key features:
- Shows TPS next to duration: "3.4s · 45 tok/s"
- Includes both output and reasoning tokens
- 250ms minimum threshold to filter noise
- Comprehensive test coverage (34 tests)

Tested with Kimi K2.5 showing ~131 tok/s.

Fixes anomalyco#5374, Closes anomalyco#6096
@Daltonganger Daltonganger force-pushed the daltonganger/pr-12721-plus-rgfix-v2 branch from fbadbb3 to 6718543 Compare February 16, 2026 21:40
@Daltonganger
Copy link
Author

@rekram1-node Quick update: I refreshed this branch on top of the latest dev to resolve merge conflicts.

Current status:

  • Branch is now mergeable (MERGEABLE)
  • Required checks have re-triggered on the updated head commit (6718543a)
  • PR description now includes linked issue references (Closes #6096, Fixes #5374) for standards compliance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Adding Experimental Calculation and Display of Tokens per second [FEATURE]: show tokens / second

2 participants