-
Notifications
You must be signed in to change notification settings - Fork 10.4k
feat(tui): add native status line template system #13885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
diegomarino
wants to merge
5
commits into
anomalyco:dev
Choose a base branch
from
diegomarino:feat/statusline-template
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+617
−25
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6157cdd
feat(tui): add native status line template system
diegomarino 2f658b6
fix: stream shell command output to cap memory at 1KB
diegomarino 7bbb14a
fix: handle statusline poll errors gracefully
diegomarino c65c0a8
fix: assert empty string for failing shell commands in test
diegomarino b7af413
ci: retrigger e2e
diegomarino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { createSignal, createEffect, onCleanup, on } from "solid-js" | ||
| import { useSDK } from "./sdk" | ||
| import { useRoute } from "./route" | ||
| import { createSimpleContext } from "./helper" | ||
|
|
||
| export const { use: useStatusLine, provider: StatusLineProvider } = createSimpleContext({ | ||
| name: "StatusLine", | ||
| init: () => { | ||
| const sdk = useSDK() | ||
| const route = useRoute() | ||
| const [templates, setTemplates] = createSignal<Record<string, string>>({}) | ||
| const [frequency, setFrequency] = createSignal(10) | ||
|
|
||
| let timer: Timer | undefined | ||
|
|
||
| const poll = async () => { | ||
| const sessionID = route.data.type === "session" ? route.data.sessionID : undefined | ||
| const result = await sdk.client.tui.statusline({ sessionID }).catch(() => undefined) | ||
| if (!result?.data) return | ||
| setTemplates(result.data.templates) | ||
| setFrequency(result.data.interval) | ||
| } | ||
|
|
||
| const start = () => { | ||
| if (timer) clearInterval(timer) | ||
| poll() | ||
| timer = setInterval(poll, frequency() * 1000) | ||
| } | ||
|
|
||
| const stop = () => { | ||
| if (!timer) return | ||
| clearInterval(timer) | ||
| timer = undefined | ||
| } | ||
|
|
||
| createEffect( | ||
| on( | ||
| () => route.data.type === "session" ? route.data.sessionID : undefined, | ||
| () => { | ||
| start() | ||
| }, | ||
| ), | ||
| ) | ||
|
|
||
| onCleanup(stop) | ||
|
|
||
| return { templates, interval: frequency } | ||
| }, | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
startfunction uses the current value offrequency()when setting up the interval, but if the interval changes after the first poll (viasetFrequency), the timer won't be updated to use the new interval. The timer continues using the old frequency value untilstartis called again. Consider restarting the timer when the frequency changes, or use a different approach to ensure the interval is dynamically updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frequency only changes once (first poll sets it from the default to the configured value). After that,
start()is re-invoked on every session change via thecreateEffect, which restarts the timer with the current frequency. A dynamic timer update mechanism would add complexity without practical benefit.