fix(tui): stop streaming markdown/code after message completes#13854
Open
mocksoul wants to merge 24 commits intoanomalyco:betafrom
Open
fix(tui): stop streaming markdown/code after message completes#13854mocksoul wants to merge 24 commits intoanomalyco:betafrom
mocksoul wants to merge 24 commits intoanomalyco:betafrom
Conversation
Resolved conflicts: - Translation files: kept dev's proper localized versions - prompt/index.tsx: preserved handoff functionality with dev's placeholderText() pattern - home.tsx: kept dev's simpler layout
…del family to reduce noise in list
…d agent updates
TextPart passed streaming={true} unconditionally, causing opentui to
always skip the last table row (treated as potentially incomplete).
Now streaming is derived from message completion state, so completed
messages render all table rows correctly.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why related: This PR addresses the same issue — preventing the last table row from being truncated/skipped after streaming completes. Both PRs are fixing the same behavior where incomplete messages cause the last row to be dropped, and both likely involve adjusting the streaming state logic for completed messages. |
opencode-agent
bot
force-pushed
the
beta
branch
from
9f943cb to
e0cf63f
Compare
opencode-agent
bot
force-pushed
the
beta
branch
16 times, most recently
from
d229e96 to
fa79b48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextPartpassesstreaming={true}unconditionally — even for completed messagesmessage.time.completedso finished messages render all rowsFixes #13855
Note
Full fix requires companion change in opentui (streaming setter must rebuild tables on
true→falsetransition). See anomalyco/opentui#696