Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce parentContainer prop for other mountpoints than document.body #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Introduce parentContainer prop for other mountpoints than document.body #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3c8b5
Introduce parentContainer props for other mountpoints than document.body
schwarmco Sep 16, 2024
89fc063
Remove Debug <pre>
schwarmco Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions examples/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@
</div>
</div>

<div class="form-group">
<label>Parent Container</label>
<div class="custom-control custom-checkbox">
<input v-model="form.parentContainer" type="checkbox" class="custom-control-input"
id="checkbox-parentContainer" true-value="#app" :false-value="null">
<label class="custom-control-label" for="checkbox-parentContainer">Mount to #app instead of body</label>
</div>
</div>

<hr>

<button type="submit" class="btn btn-primary mr-3">Show notification</button>
Expand Down Expand Up @@ -116,6 +125,7 @@ export default {
dismissible: true,
queue: false,
position: 'bottom-right',
parentContainer: null,
onClick: this.onClick,
onDismiss: this.onDismiss,
},
Expand Down
16 changes: 11 additions & 5 deletions src/js/Component.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ export default defineComponent({
type: Boolean,
default: true
},
parentContainer: {
type: String,
default: null
}
},
data() {
return {
Expand All @@ -83,8 +87,8 @@ export default defineComponent({
},
methods: {
setupContainer() {
this.parentTop = document.querySelector('.v-toast.v-toast--top');
this.parentBottom = document.querySelector('.v-toast.v-toast--bottom');
this.parentTop = this.parentContainerElement.querySelector('.v-toast.v-toast--top');
this.parentBottom = this.parentContainerElement.querySelector('.v-toast.v-toast--bottom');
// No need to create them, they already exists
if (this.parentTop && this.parentBottom) return;

Expand All @@ -98,9 +102,8 @@ export default defineComponent({
this.parentBottom.className = 'v-toast v-toast--bottom'
}

const container = document.body;
container.appendChild(this.parentTop);
container.appendChild(this.parentBottom);
this.parentContainerElement.appendChild(this.parentTop);
this.parentContainerElement.appendChild(this.parentBottom);
},

shouldQueue() {
Expand Down Expand Up @@ -189,6 +192,9 @@ export default defineComponent({
}
}
},
parentContainerElement() {
return this.parentContainer ? document.querySelector(this.parentContainer) : document.body
}
},
beforeUnmount() {
eventBus.off('toast-clear', this.dismiss)
Expand Down
4 changes: 3 additions & 1 deletion src/js/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ export const useToast = (globalProps = {}) => {

const propsData = Object.assign({}, defaultProps, globalProps, options);

const instance = createComponent(ToastComponent, propsData, document.body);
const parentContainer = propsData.parentContainer ? document.querySelector(propsData.parentContainer) : document.body

const instance = createComponent(ToastComponent, propsData, parentContainer);

return {
dismiss: instance.ctx.dismiss
Expand Down
Loading