-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show menu bar in full screen #3682
base: main
Are you sure you want to change the base?
Show menu bar in full screen #3682
Conversation
I can imagine some people complaining about this change. But right now, the menu bar actually re-appears in full-screen mode when you exit the review screen. Can we maybe fix that and show the menu bar only on hover instead? |
As discussed in the original issue (#3647 (comment) and subsequent comments), permanently displaying the Therefore, the changes introduced in this PR are not aligned with the desired direction. |
@abdnh @YukiNagat0 I've implemented the change for showing the menu bar when hovering near the top of the screen as discussed. |
@KartikSharma0, I apologize for the quibble, but I believe the The flaw in the current (master branch) implementation is that the The goal is to decouple the |
Thanks for the thorough explanation. I will look into this issue from the approach you mentioned. |
Fix: #3647
EDIT: The menu bar will be visible to users in full screen when the cursor hovers near the top of the screen.
1. Removedhide_menubar
function when full screen is toggled on Windows and non-mac systems.3. Added theshow_menubar
function in theon_toggle_full_screen
function without conditional statement.Added my name in CONTRIBUTORS as this is my first PR for this project.