Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Deployed the Application on Heroku and added Instruction guide with other files #1160

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

DARK-art108
Copy link

Description

Deploy the web app to Heroku, this will be helpful for testers.

Fixes #1135

Type of Change:

Delete irrelevant options.

  • Code
  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

The Heroku app is deployed on https://vms-r.herokuapp.com/ and tested

Checklist:

Delete irrelevant options.

  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@DARK-art108
Copy link
Author

Hello, @isabelcosta I have added the additional files which will be required to deploy the application to Heroku and made changes which you have suggested in the previous pr #1159.

You can close the previous PR #1159 and review this one for further changes to be done.

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1160 into develop will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1160      +/-   ##
===========================================
- Coverage    87.18%   86.96%   -0.23%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
- Hits          3537     3528       -9     
- Misses         450      457       +7     
- Partials        70       72       +2     
Impacted Files Coverage Δ
vms/event/views.py 78.05% <0.00%> (-1.27%) ⬇️
vms/shift/views.py 61.40% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0189ce8...47856a5. Read the comment docs.

@haelmj
Copy link

haelmj commented Nov 18, 2020

@DARK-art108 Could you please verify that the app is still deployed on Heroku? Navigating to the URL you provided here, returns this error message:
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to Heroku and write instructions on how to do that
2 participants