feat(ios): wrapper implementation #11
Conversation
berendsliedrecht
commented
Jan 22, 2025
•
berendsliedrecht
commented
- ios wrapper full implementation for RN >= 75. (old arch tested only right now)
berendsliedrecht
force-pushed
the
ios-rn-mdoc
branch
4 times, most recently
from
8b953ba to
df8a37e
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
ios-rn-mdoc
branch
from
df8a37e to
4395516
Compare
|
|
||
| if defined?(:spm_dependency) | ||
| spm_dependency(s, | ||
| url: 'https://github.com/berendsliedrecht/eudi-lib-ios-iso18013-data-transfer.git', |
There was a problem hiding this comment.
Might be good to add a comment with reason and link to the code: https://github.com/berendsliedrecht/eudi-lib-ios-iso18013-data-transfer/tree/send-device-response-manually
Also -- maybe good to clean up the formatting in that branch a bit so it's easy to see what changed compared to the EUDI wallet implementation.
| @@ -9,13 +10,14 @@ | |||
| "prebuild": "expo prebuild --no-install" | |||
| }, | |||
| "dependencies": { | |||
| "@animo-id/expo-mdoc-data-transfer": "../", | |||
| "@animo-id/expo-mdoc-data-transfer": "link:../", | |||
There was a problem hiding this comment.
Does react native support linked packages? I didn't think so?
There was a problem hiding this comment.
well it works, so I guess it does?
example/yarn.lock
Outdated
There was a problem hiding this comment.
No there was a weird circular reference between the example app and library. Can be fixed by moving to a workspace I guess.
ios/MdocDataTransfer.swift
Outdated
| @objc | ||
| func initialize() -> String { | ||
| guard bleServerTransfer == nil else { | ||
| return "" |
There was a problem hiding this comment.
DO you mean return an error string? I not mind it too much, but reinitialization calls can happen quite a bit with RN and that would make the UX quite annoying.
ios/MdocDataTransfer.swift
Outdated
| func initialize() -> String { | ||
| guard bleServerTransfer == nil else { | ||
| return "" | ||
| } | ||
|
|
||
| do { | ||
| bleServerTransfer = try MdocGattServer(parameters: [ | ||
| InitializeKeys.document_json_data.rawValue: [], | ||
| InitializeKeys.trusted_certificates.rawValue: [], | ||
| InitializeKeys.send_response_manually.rawValue: true, | ||
| ]) | ||
| bleServerTransfer?.delegate = self | ||
| } catch { | ||
| return error.localizedDescription | ||
| } | ||
|
|
||
| return "" | ||
| } |
There was a problem hiding this comment.
Why return an empty string? on iOS it returns null
There was a problem hiding this comment.
its void on Android and a string on iOS, I don't understand what you mean?
There was a problem hiding this comment.
On android it's null? Returning empty string is just weird api IMO.
| let cipherData = try sessionEncryption.encrypt(byteArray) | ||
| let sd = SessionData(cipher_data: cipherData, status: 20) | ||
| try bleServerTransfer.sendResponse( | ||
| Data(sd.encode(options: CBOROptions()))) |
There was a problem hiding this comment.
Is this BLE session encryption or mdoc specific encryption? Does the android library also handle this? or is that handled outside of this library (e.g. in mdoc library?)
There was a problem hiding this comment.
This is handled exactly like the android side. I can also move this to the library.
ios/MdocDataTransfer.swift
Outdated
| rejector = nil | ||
| resolver = nil | ||
|
|
||
| return "" |
There was a problem hiding this comment.
again not sure on the empty string?
There was a problem hiding this comment.
empty string = no error
string = error
Could not find another pattern that works. Open to improvements in a follow up PR.
pnpm-lock.yaml
Outdated
| const usageDescription = props?.ios?.bluetoothDescription || defaultDescription | ||
|
|
||
| if (c.ios?.infoPlist) { | ||
| c.ios.infoPlist.NSBluetoothAlwaysUsageDescription = usageDescription |
There was a problem hiding this comment.
this could already have been set by the app config? Maybe we should only set it if not already set?
There was a problem hiding this comment.
I've seen this pattern multiple times to provide it to the package, don't really see the issue with doing it like this. It is optional anyways.
Yeah. However I would want to wait until it is slightly more stable again... react native, and expo, like to push broken stuff which makes being compatible with the latest version a pain..... |
berendsliedrecht
force-pushed
the
ios-rn-mdoc
branch
from
8102adc to
266fba9
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
ios-rn-mdoc
branch
from
266fba9 to
a2e86e7
Compare
