Skip to content

feat: better support pnpm symlinked node modules #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devversion merged 1 commit into from
Jan 28, 2026
Merged

feat: better support pnpm symlinked node modules #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions runner/configuration/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ export const DEFAULT_SUMMARY_MODEL = 'gemini-2.5-flash-lite';
/** Name of the root folder where we store LLM-generated code for debugging */
export const LLM_OUTPUT_DIR = join(rootDir, 'llm-output');

/**
* Path for WCS temporary directories.
*
* We want temporary workspaces to be nested inside the root project to
* better support symlinked node modules. E.g. Turbopack will otherwise
* fail if symlinked node modules are not reachable via parent directories.
*/
export const WCS_BASE_TMP_DIR = join(rootDir, 'tmp-workspaces');

/**
* Number of times we'll try to ask LLM to repair a build failure,
* providing the build output and the code that causes the problem.
Expand Down
8 changes: 5 additions & 3 deletions runner/orchestration/file-system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {tmpdir} from 'os';
import {LLM_OUTPUT_DIR} from '../configuration/constants.js';
import {LLM_OUTPUT_DIR, WCS_BASE_TMP_DIR} from '../configuration/constants.js';
import {Environment} from '../configuration/environment.js';
import {
copyFolderExcept,
Expand All @@ -25,13 +24,15 @@ const PENDING_INSTALLS = new Map<string, Promise<void>>();
* @param env Environment that is currently being run.
* @param rootPromptDef Definition of the root prompt.
* @param progress Logger to use to log out the current progress.
* @param tmpdirBasePath Base path for temporary directories (like `/tmp`).
* @param outputDirectory Custom output directory specified by the user.
* @returns Temporary directory in which to build and a function used to clean in up.
*/
export async function setupProjectStructure(
env: Environment,
rootPromptDef: RootPromptDefinition,
progress: ProgressLogger,
tmpdirBasePath: string = WCS_BASE_TMP_DIR,
outputDirectory?: string,
) {
let directory: string;
Expand All @@ -48,7 +49,8 @@ export async function setupProjectStructure(
cleanup = () => Promise.resolve();
} else {
// When outputting to the temporary directory, make sure that the directory is unique.
directory = await mkdtemp(join(tmpdir(), `fw-${env.id}-build-${rootPromptDef.name}`));
await mkdir(tmpdirBasePath, {recursive: true});
directory = await mkdtemp(join(tmpdirBasePath, `fw-${env.id}-build-${rootPromptDef.name}`));

cleanup = async () => {
try {
Expand Down
Loading