Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(m3-tokens): wrong hue reference #29902

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

simonkovtyk
Copy link

@simonkovtyk simonkovtyk commented Oct 21, 2024

Hi there

Recently, I made some own implementations to support multiple paletts for m3 and I orientated my code at the token generation here.

I found out, that Angular Material is not using the right tokens for some color rules as described in the offical Figma Template.

Overview

Light mode

Token Hue (Angular Material) Hue (Material spec)
on-primary-container P-10 P-30
on-secondary-container S-10 S-30
on-tertiary-container T-10 T-30
on-error-container E-10 E-30

Dark mode

Token Hue (Angular Material) Hue (Material spec)
on-primary-container P-10 P-30
on-secondary-container S-10 S-30
on-tertiary-container T-10 T-30
on-error-container E-10 E-30

Copy link

google-cla bot commented Oct 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant