Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-federation-runtime) runtime crash with non-JS routing (like static HTML apps or SSR apps) #693

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Aukevanoost
Copy link

This issue is an edge case:

Since the ‘host remoteEntry.json’ fetch is hardcoded as a relative URL, therefore when used in Stateful SSR websites like (Java Wicket, Ruby, PHP etc.) or static HTML websites. The relative url will fail on all pages that are not the homepage.

Example

With this file structure

/
└── public/
    ├── products/
    │   └── index.html
    ├── contact/
    │   └── index.html
    ├── index.html
    └── remoteEntry.json

RemoteEntry.json resolves on

** RemoteEntry.json fails to resolve on**

Solution

Assuming these websites don't have anything to share or expose anyway, an 'opt-out' functionality for the host that prevents the fetch of a potentially useless remoteEntry.json object, combined with a way to provide an url for other edge cases. With as default the hardcoded url to be backwards compatible.

rainerhahnekamp and others added 6 commits September 29, 2024 01:52
Issues can be created for three categories:
- Bug Reports
- Feature Requestion
- General Question
…ithub-issue-template

docs: add template for GitHub Issues
fix(nf): fix esbuild target for shared libs
@Aukevanoost Aukevanoost changed the title [native-federation-runtime] Fix runtime crash with non-JS routing (like static HTML apps or SSR apps) fix(native-federation-runtime) runtime crash with non-JS routing (like static HTML apps or SSR apps) Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants