fix(native-federation-runtime) runtime crash with non-JS routing (like static HTML apps or SSR apps) #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is an edge case:
Since the ‘host remoteEntry.json’ fetch is hardcoded as a relative URL, therefore when used in Stateful SSR websites like (Java Wicket, Ruby, PHP etc.) or static HTML websites. The relative url will fail on all pages that are not the homepage.
Example
With this file structure
RemoteEntry.json resolves on
** RemoteEntry.json fails to resolve on**
Solution
Assuming these websites don't have anything to share or expose anyway, an 'opt-out' functionality for the host that prevents the fetch of a potentially useless remoteEntry.json object, combined with a way to provide an url for other edge cases. With as default the hardcoded url to be backwards compatible.