-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PR based on #142 #145
Open
w2sv
wants to merge
40
commits into
anggrayudi:master
Choose a base branch
from
w2sv:release/2.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into release/2.0.0
…proguard files | Clean up build files
…FolderResult.Starting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up rewriting all the still relevant changes with #142 as base branch. Somehow all the commits you did to the branch are now included in the PR too and I couldn't quite figure out how to fix that, as I'm not sooo well versed with git yet.
Once again, the list of the changes I made:
Internal
com.vanniktech:gradle-maven-publish-plugin
to 0.28.0,org.jetbrains.dokka:dokka-gradle-plugin
to 1.9.20, gradle to 8.8ExampleUnitTest
s,buildFeatures { viewBinding = true }
from the storage build file,deps.coroutines.core
kotlin
source sets and the sample java files into ajava
source set, respectivelyFileWrapper
implementations value classes, which enables the compiler to optimize away lots of the overhead introduced by the wrapper class referenceSingleFileResult.Validating
andSingleFileResult.Preparing
@FloatRange(0.0, 100.0)
annotation toInProgress.progress
fields which clarifies its value rangeBreaking
implementation
s instead ofapi
s, except fordeps.documentfile
SingleFileResult.CountingFiles
,SingleFileResult.Starting
,SingleFolderResult.Starting
, which weren't ever emittedSingleFileResult.Completed
to the following for type clarityZipDecompressionResult.Completed.zipFile: DecompressedZipFile
MediaFile.AccessCallback
interface, and instead introduced a MediaFilevar onWriteAccessDenied: OnWriteAccessDenied? = null
constructor parameter withtypealias OnWriteAccessDenied = (mediaFile: MediaFile, sender: IntentSender) -> Unit