Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qupath 24bit images #21

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Qupath 24bit images #21

merged 2 commits into from
Aug 15, 2024

Conversation

JLrumberger
Copy link
Collaborator

@JLrumberger JLrumberger commented Aug 15, 2024

Just a small fix to the other PR that handled the 24bit qupath segmentation maps. This one includes support for qupath seg maps that are either saved as channels first or channels last, according to the example data that ofra provided in #18. I'll merge without review, because the change is so small @ngreenwald.

@JLrumberger JLrumberger merged commit dc68d43 into main Aug 15, 2024
11 checks passed
@JLrumberger JLrumberger deleted the qupath_24bit_images branch August 15, 2024 10:45
@ofrag
Copy link

ofrag commented Aug 25, 2024

Just to close the loop: I checked with fresh export from QuPath and everything work smoothly. Checked on small FOV as well as whole slide of ~11,000*11,000 pixels, with >70K cells. Many thanks for the support !

@ofrag
Copy link

ofrag commented Aug 25, 2024

I suggest also considering an implementation of Nimbus extension for QuPath, though I guess this will require some support from the QuPath team. The advantage I see is that it will allow to skip the export of the channel images, and to integrate Nimbus results into QuPath workflows. QuPath extensions for Stardist and Cellpose already break the image into overlapping tiles and resolve the results in the overlap regions. Stardist-QuPath extension process the tiles in parallel, Cellpose-QuPath extension does not. The challenge I expect is how to make use of the GPU / parallel processing.

@JLrumberger
Copy link
Collaborator Author

Thanks for testing! I'll look into how I can make Nimbus available on Qupath, but I think it's not super straight forward unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants