Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JetChat] Add glance widget for JetChat App #1424 #1425

Merged
merged 24 commits into from
Jan 10, 2025
Merged

[JetChat] Add glance widget for JetChat App #1424 #1425

merged 24 commits into from
Jan 10, 2025

Conversation

shangeethsivan
Copy link
Contributor

@shangeethsivan shangeethsivan commented Jul 3, 2024 •
edited
Loading

Added an Unreads widget for the JetChat app using Glance. Also has a option to add widget to home screen on the app.

Glance.Widget.Recording.webm

Fixes #1424

@shangeethsivan shangeethsivan requested a review from a team as a code owner July 3, 2024 16:34
@shangeethsivan shangeethsivan requested a review from arriolac July 3, 2024 16:34
@riggaroo riggaroo removed the request for review from arriolac August 14, 2024 14:21
@shangeethsivan shangeethsivan changed the base branch from main to tm/root-project October 17, 2024 06:23
@shangeethsivan shangeethsivan changed the base branch from tm/root-project to main October 17, 2024 06:23
mlykotom
mlykotom reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Jetchat/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
Jetchat/app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Jetchat/app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Jetchat/app/src/main/res/layout/widget_loading_layout.xml Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/FakeData.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/res/layout/widget_error_layout.xml Outdated Show resolved Hide resolved
Jetchat/app/src/main/res/layout/widget_error_layout.xml Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt Show resolved Hide resolved
@mlykotom mlykotom requested a review from secondsun October 21, 2024 12:08
secondsun
secondsun requested changes Oct 28, 2024
View reviewed changes
Copy link

@secondsun secondsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added my feedback, and +1 all of @mlykotom's points.

Are you expecting to add live data to the widget too, or only stick with static data?

Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/WidgetReceiver.kt Show resolved Hide resolved
@shangeethsivan
Copy link
Contributor Author

Thanks for the review @secondsun and @mlykotom will work on these over the weekend and will re-request a review.

@shangeethsivan
Copy link
Contributor Author

@secondsun @mlykotom Can you guys take a look at the PR now ?

secondsun
secondsun requested changes Nov 12, 2024
View reviewed changes
Copy link

@secondsun secondsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one thing with linting. Line is too long.

Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt Outdated Show resolved Hide resolved
mlykotom
mlykotom requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check some of the comments, after that it's lgtm :)

Thank you and sorry for the long turnaround!

Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt Outdated Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt Show resolved Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/JetchatApplication.kt Outdated Show resolved Hide resolved
@shangeethsivan
Removed the DI pattern and added the unread messages in the FakeData.…
668120e 
…kt class as initially implemented. Also propagating the requiresApi check to WidgetDiscoverability composable.
@shangeethsivan
Copy link
Contributor Author

shangeethsivan commented Jan 9, 2025 •
edited
Loading

@mlykotom I have addressed the last set of comments hope this is the last one 😅 . Also the issue that was related to this PR has auto closed should I reopen it ?

#1424 - Im not seeing a reopen option here.

@mlykotom
Copy link
Contributor

mlykotom commented Jan 9, 2025

There's one more thing -- the unused MessagesRepository + pls fix the format. Otherwise this is LGTM :)

@mlykotom mlykotom merged commit 8abb7d2 into android:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlykotom mlykotom mlykotom approved these changes

@secondsun secondsun secondsun approved these changes

@AniruddhaKulk AniruddhaKulk Awaiting requested review from AniruddhaKulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Glance Widget for JetChat App
4 participants
@shangeethsivan @mlykotom @secondsun @AniruddhaKulk