Skip to content

Rename smurf named methods#942

Open
dturner wants to merge 1 commit intoandroid:mainfrom
dturner:remove-smurf-naming
Open

Rename smurf named methods#942
dturner wants to merge 1 commit intoandroid:mainfrom
dturner:remove-smurf-naming

Conversation

@dturner
Copy link
Collaborator

@dturner dturner commented Apr 17, 2023

Here's what I've done and why:

  • Removed Task from TaskRepository methods to avoid smurf naming e.g createTask becomes just create.
  • Changed get to observe for methods which return a Flow. This is less verbose and more accurate than getTaskStream.
  • Methods which return a List<Task> have All after the verb e.g. observeAll and `clearAllCompleted.

@dturner dturner requested review from astamato and mmoczkowski June 5, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments