fix: show save button on New task screen when keyboard is displayed#1056
fix: show save button on New task screen when keyboard is displayed#1056etCoderDysto wants to merge 2 commits intoandroid:mainfrom
Conversation
Summary of ChangesHello @etCoderDysto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a UI issue where the floating action button (FAB) for saving a new task was hidden by the soft keyboard on the 'New task' screen. By adjusting the layout to account for keyboard insets, the FAB now correctly repositions itself, improving the user experience for task creation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the save button on the 'New task' screen is obscured by the on-screen keyboard. The change correctly applies window insets padding to the Scaffold to ensure the entire screen, including the floating action button, shifts up when the keyboard is visible. My review includes a suggestion to use a more concise and idiomatic API available in Jetpack Compose for this purpose, which improves code readability and simplifies imports.
| modifier = modifier | ||
| .fillMaxSize() | ||
| .windowInsetsPadding(WindowInsets.ime), |
There was a problem hiding this comment.
For better readability and conciseness, you can use the imePadding() modifier, which is a shorthand for windowInsetsPadding(WindowInsets.ime).
Using it will simplify the code here and also reduce the number of imports needed. You'll need to replace import androidx.compose.foundation.layout.WindowInsets, import androidx.compose.foundation.layout.ime, and import androidx.compose.foundation.layout.windowInsetsPadding with a single import androidx.compose.foundation.layout.imePadding.
| modifier = modifier | |
| .fillMaxSize() | |
| .windowInsetsPadding(WindowInsets.ime), | |
| modifier = modifier | |
| .fillMaxSize() | |
| .imePadding(), |
Title: On "New Task" screen when the keyboard is opened, "Save" floating action button is hidden behind the keyboard and it makes it difficult to save a task.
Steps:
Expected Result: Save FAB button shouldn't be hidden behind the keyboard.
Actual Result: Save FAB button is hidden behind the keyboard.
Before fix
Before.Screen.Recording.2026-02-17.at.2.20.40.in.the.afternoon.mp4
After fix
After.Screen.Recording.2026-02-17.at.2.12.24.in.the.afternoon.mp4