Skip to content

Comments

fix: show save button on New task screen when keyboard is displayed#1056

Open
etCoderDysto wants to merge 2 commits intoandroid:mainfrom
etCoderDysto:fix_save_button_is_hidden_behind_keyboard
Open

fix: show save button on New task screen when keyboard is displayed#1056
etCoderDysto wants to merge 2 commits intoandroid:mainfrom
etCoderDysto:fix_save_button_is_hidden_behind_keyboard

Conversation

@etCoderDysto
Copy link

@etCoderDysto etCoderDysto commented Feb 17, 2026

Title: On "New Task" screen when the keyboard is opened, "Save" floating action button is hidden behind the keyboard and it makes it difficult to save a task.

Steps:

  1. Open app
  2. Click on "+" FAB
  3. Click on Title input field, and enter title
  4. Click on Task details field, and enter description

Expected Result: Save FAB button shouldn't be hidden behind the keyboard.
Actual Result: Save FAB button is hidden behind the keyboard.

Before fix

Before.Screen.Recording.2026-02-17.at.2.20.40.in.the.afternoon.mp4

After fix

After.Screen.Recording.2026-02-17.at.2.12.24.in.the.afternoon.mp4

@gemini-code-assist
Copy link

Summary of Changes

Hello @etCoderDysto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI issue where the floating action button (FAB) for saving a new task was hidden by the soft keyboard on the 'New task' screen. By adjusting the layout to account for keyboard insets, the FAB now correctly repositions itself, improving the user experience for task creation.

Highlights

  • UI Visibility Fix: Implemented a fix to ensure the 'Save' button remains visible on the 'New task' screen even when the soft keyboard is displayed, preventing it from being obscured.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • app/src/main/java/com/example/android/architecture/blueprints/todoapp/addedittask/AddEditTaskScreen.kt
    • Added imports for WindowInsets, ime, and windowInsetsPadding to handle keyboard-related layout adjustments.
    • Applied windowInsetsPadding(WindowInsets.ime) to the Scaffold modifier to automatically adjust its padding when the keyboard is active.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where the save button on the 'New task' screen is obscured by the on-screen keyboard. The change correctly applies window insets padding to the Scaffold to ensure the entire screen, including the floating action button, shifts up when the keyboard is visible. My review includes a suggestion to use a more concise and idiomatic API available in Jetpack Compose for this purpose, which improves code readability and simplifies imports.

Comment on lines 73 to 75
modifier = modifier
.fillMaxSize()
.windowInsetsPadding(WindowInsets.ime),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and conciseness, you can use the imePadding() modifier, which is a shorthand for windowInsetsPadding(WindowInsets.ime).

Using it will simplify the code here and also reduce the number of imports needed. You'll need to replace import androidx.compose.foundation.layout.WindowInsets, import androidx.compose.foundation.layout.ime, and import androidx.compose.foundation.layout.windowInsetsPadding with a single import androidx.compose.foundation.layout.imePadding.

Suggested change
modifier = modifier
.fillMaxSize()
.windowInsetsPadding(WindowInsets.ime),
modifier = modifier
.fillMaxSize()
.imePadding(),

@etCoderDysto etCoderDysto marked this pull request as ready for review February 17, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant